devot:eeDevoted to ExpressionEngine

Hi Yuri,

I’ve noticed a couple issues with this module in EE 2.6.

1. Lots of Deprecated notices that are stacking up HUGE SQL queries for the logging. Any chance of getting those updated?

2. The comment variables are being parsed before the module can get to them. For example, having {email} in a comment form or thread list will be replaced by the current logged in user. So, if I’m logged in then all the comments show as being by me. If *no one* is logged in the string is replaced with nothing.

Big fan of this module by the way. It fills such an obvious niche it’s amazing EL hasn’t absorbed it yet. Good job.

Thanks,
Eric

Hi Eric,

the latest version fo module should have issue #2 fixed, are you running latest module version and still have this problem?

I’ll take care of depracated functions soon, a few of my modules need that, I just need a bit more time :)

Yeah, I’m running the latest versions of EE and Threaded Comments.

Thanks,
Eric

Great plugin thanks for developing it.

I am not posting this to rush you just as information regarding the deprecated functions you have on your to do list.

This is a warning I am getting in EE 2.6. Thanks a lot

______________________________________________
Deprecated function remove_double_slashes() called in system/expressionengine/third_party/threaded_comments/mod.threaded_comments.php on line 1181.
From template tag exp:threaded_comments:display in blog/post.
Deprecated since 2.6. Use reduce_double_slashes() instead.

FWIW, a little rush wouldn’t be too out of line though that’s NO fault of your fine product. EE does a SELECT query for EVERY deprecated method call so with Threaded Comments having so many of them, it’s adding on around 6 SELECT statements per comment. That’s a lot. I had a site that had over 200 SELECT statements on a single article page just due to EEs stupid handling of their logging.

Just throwing it out there.

Thanks,
Eric

I hope to get all those warnings fixed by end of this week.
I did not receive developer preview’s copy of EE 2.6. release, and now need to go through all of my modules to make sure they work well with all latest EE changes - so please give me just a couple more days.
I know these errors are annoying - but gladly they’re not critical for site performance. I’ll fix them soon; thank you for your patience :)

Just released an update - please give it a try.
Please let me know if it still raises any issues.

Hi Yuri,

I am using this module in EEv2.6. On submitting comment, I am seeing blank page. While investing I found that the code (around line number 200 in mod.threaded_comments.php) is blocking for further execution.

Could you please suggest me.

Thanks,

Hi Bhashkar,

do you have any comment-related extensions?
Can you try disabling extensions and see if it solves the issue?
Also, set EE debugging preferences to show errors to everyone and see if you get any message instead of blank page.

Hi,

I’m getting error as well using EE2.6.1 and the latest Threaded Comments module

Could one of the files get corrupt? Try replacing the files.

FYI, Threaded Comments does not use ob_start() function by itself.

I’ve removed the folder and uploaded the latest 2.4.4 again and I get the same error

Yuri Salimovskiy - 11 May 2013 12:35 AM

Hi Bhashkar,

do you have any comment-related extensions?
Can you try disabling extensions and see if it solves the issue?
Also, set EE debugging preferences to show errors to everyone and see if you get any message instead of blank page.

Thanks Yuri,

Let me check for it. I hope, it would fix the issue.

Thanks,

YM, where do you see the error? In Control Panel or on site pages? Does it go away when you uninstall the module?

Hi,

I guess its not a wise thing to uninstall the module as I will loose connection in the database?

Hi,

I forgot to say this error on the frond end, not the backend, only for articles with comments