Module

Developer
Supported

Threaded Comments

ExpressionEngine 2

Back to this add-on's main page
View Other Add-ons From Yuri Salimovskiy

     

You must be logged in to post.

Render wrong link with 2 var: {next_link} & {prev_link}

Bug Report

Ngon Com
Ngon Com

Hi Yuri!

I’ve test and seem Threaded Comments render wrong with 2 var: {next_link} & {prev_link}

{exp:threaded_comments:display limit="3"}
{comments}
--- --- ---
{/comments}

{paginate}
          {if next_page}{next_link}{
/if}
          {if previous_page}{prev_link}{
/if}
{
/paginate}
{
/exp:threaded_comments:display} 

Above code will generate 2 links:

domain.com/productP6/
domain.com/productP0

When the right links will be:

domain.com/product/P6
domain.com/product/P0 

The problem is with “/”, can you review this.

Thank you!

P/S: Does Threaded Comments 2.4.7 support EE 2.8? Thank Yuri!

Yuri Salimovskiy
# 1
Developer
Yuri Salimovskiy

Thank you for the report - released a fix!

I did not test TC with EE2.8 yet.

Ngon Com
# 2
Ngon Com

Thank you so much for your fast reply and fix bug!

Seem there are another bug appeared :D, var {absolute_count_root} return wrong value!

When using with pagination (limit = 3, when I have 10 root comment): at page = 1, var {absolute_count_root} = 3 (wrong) [the true value is 10]

Thank so much, Yuri!

Yuri Salimovskiy
# 3
Developer
Yuri Salimovskiy

{absolute_count_root} is not intented to display total number of comments, it’s a counter that persists though all pagination pages.

If you need total number of root comments, use {total_threads}

Ngon Com
# 4
Ngon Com

I using {total_threads} and it correct

But, what do you say when 2 var return same value: {count_root} = {absolute_count_root}? Aren’t they different?

Yuri Salimovskiy
# 5
Developer
Yuri Salimovskiy

On first pagination page those variables will have same value

loemrntdherid1
# 6
loemrntdherid1