Protected Links
ExpressionEngine 2, ExpressionEngine 3, ExpressionEngine 4, ExpressionEngine 5, ExpressionEngine 6
Back to this add-on's main page
View Other Add-ons From Yuri Salimovskiy
Issue with 3.1.0, links showing as expired when they aren’t
Support Request
Boiler Room Digital
|
Posted: 16 December 2020 06:29 AM |
|
|
|
Hello,
Couple of issues - firstly a hopefully simple one. I had 3.0.0 installed (on a 3.5.17 EE install). I uploaded the files for 3.1.0. I’ve clicked the Update to 3.1.0 button, and it’s now showing that 3.1.0 is installed, but I still see the update button. Not sure what is going on here.
Secondly, I use Protected Links to hide links to Photos which I store above the web root, so they’re only available for logged in users. As a Super Admin, these were working fine, but for all other users, the photos weren’t appearing - the error was that the Link had Expired. None of the links have an expiry date in the database. I found that because the expiry date column was a number, an empty expiry returns “0” rather than an empty string. Thus editing line 87 of mod.protected_links.php to:
if ($link_q->row(‘expires’)!=’’ && $link_q->row(‘expires’)!=0 && ee()->localize->now > $link_q->row(‘expires’))
From
if ($link_q->row(‘expires’)!=’’ && ee()->localize->now > $link_q->row(‘expires’))
Prevented the error. Does this seem sensible? Is this a bug?
|
|
|
Yuri Salimovskiy
|
Posted: 17 December 2020 10:27 AM |
# 1
|
|
Developer
|
Thanks for catching this! The !=0 check was present in few places, but not everywhere.
The new version has been packaged and uploaded to devot:ee (no version number update)
|
|
|
Boiler Room Digital
|
Posted: 21 December 2020 07:55 AM |
# 2
|
|
|
Thanks!
|
|
|