Minimee
ExpressionEngine 2
Back to this add-on's main page
View Other Add-ons From John D. Wells
Not parsing queue
Bug Report
|
James Spibey
|
| Posted: 05 December 2013 10:05 AM |
|
|
|
|
Hi John,
This further to my last post (http://devot-ee.com/add-ons/support/minimee/viewthread/11281) . This time it’s a different site, not using CE Cache (not even installed), EE 2.7.2, Minimee 2.1.9.
If I have the following template
{exp:minimee:js queue="custom"}
< script type='text/javascript' src="/INCLUDES/JQUERY/swfobject.js">< /script>
{/exp:minimee:js}
{exp:minimee:display js="custom"}
(added spaces to the script tag because of Devotee parsing it out)
The result is
{268b32b4e7f61fce74a20164f750ac0e929900ee}
Any ideas why this isn’t parsing?
|
|
|
|
|
John D Wells
|
| Posted: 05 December 2013 10:23 AM |
# 1
|
|
|
Developer
|
Hi James,
Any chance you’re wrapping either the queue or display tags in conditionals? Or are you using any other caching, stash, template caching, etc?
Cheers,
John
|
|
|
|
|
James Spibey
|
| Posted: 05 December 2013 10:25 AM |
# 2
|
|
|
|
Not in this example, the template I’m testing with is exactly as shown above. No caching or anything else
|
|
|
|
|
John D Wells
|
| Posted: 05 December 2013 10:47 AM |
# 3
|
|
|
Developer
|
Odd - and if you empty out the Minimee cache folder and re-run, it still happens?
Is there a chance that the display tag is being run before the queue tag? Is it a parse order issue?
Cheers,
John
|
|
|
|
|
James Spibey
|
| Posted: 05 December 2013 10:50 AM |
# 4
|
|
|
|
Still happens if I empty out the cache folder, and I’m not sure how it could be parse order related? The template is as shown above so can’t see how it would be parsed in the incorrect order?
Is there anything else I can check? Logs, extension hooks priorities etc etc?
|
|
|
|
|
John D Wells
|
| Posted: 05 December 2013 10:55 AM |
# 5
|
|
|
Developer
|
it is literally as you’ve pasted it? Are you queu’ing anything else, is it possible that it’s that other queue tag that’s being missed? If you aren’t queue’ing anything, why go with the queue method then, can you just do a straight minimee:js tag?
It could be a hook conflict - can you do a search in the extensions table for the “template_post_parse” hook, any other add-ons using it?
|
|
|
|
|
James Spibey
|
| Posted: 05 December 2013 11:10 AM |
# 6
|
|
|
|
Yes template is exactly as shown, and the reason it’s like this is that this is the simplest way to reproduce the error. I’m also seeing it in a much more complex nested template but if I can fix it in this very simple example I can then see if it fixes the more complex example.
For the template_post_parse, there is one for minimee (priority 10) and one for Structure 3.2.4 (priority 10)
|
|
|
|
|
John D Wells
|
| Posted: 05 December 2013 11:17 AM |
# 7
|
|
|
Developer
|
Hi James,
Ah ok gotcha - well thanks for doing that first! :)
I’ve just had a look at a copy of Structure 3.2.4, and indeed there may be a problem there. I can see Structure’s hook is (edit: NOT) giving other add-ons a chance to operate upon that hook.
If you’re willing, can you jump into ext.structure.php and add the following to the start of the template_post_parse() method, right at line 444:
// play nice with others
if (isset($this->EE->extensions->last_call) && $this->EE->extensions->last_call)
{
$final_template = $this->EE->extensions->last_call;
}
That’s untested, but it’s boilerplate “play nice with others” extension code. Can you let me know what happens?
Cheers,
John
|
|
|
|
|
James Spibey
|
| Posted: 05 December 2013 11:24 AM |
# 8
|
|
|
|
Yep, that fixed it, and also fixed my more complex example.
Thanks for the prompt response
|
|
|
|
|
John D Wells
|
| Posted: 05 December 2013 11:26 AM |
# 9
|
|
|
Developer
|
Ace - glad we solved it. Thanks for your help in narrowing down the problem!
Cheers,
John
|
|
|
|
