devot:eeDevoted to ExpressionEngine

EE 2.2 Build 20110622
Minimee 1.1.3

This is kind of a bug report and a feature request in one.

We were base64 encoding some images, and I think the code that rewrites the background image urls was breaking in some instances. The one image (which was ridiculously long so I won’t paste it in here) was working fine and the URL didn’t get rewritten at all.

But the second image:

Was being rewritten as:

I went into libraries/cssmin.php and commented out lines 370-392 (the bit that does the URL rewriting) and that solved the problem.

So I guess the feature request would be a way to turn off the URL rewriting. Let me know if I can provide any more details.

Hi Trevor,

Hmm… OK, I might be able to work this out.  Since you seem to not mind getting your hands dirty with code, would you mind trying something?

1. First of all, restore cssmin.php to it’s original code.
2. Open up pi.minimee.php, go to line 847, and remove the second parameter passed to $this->_minify().
3. Then go to line 954, and again remove the second parameter passed to $this->_minify().

Then manually clear your Minimee cache (or update any of your CSS files), and see what happens.  That should skip the URL prepending altogether, and hopefully leave your image intact.

If that works for you, I’ll plan on supporting a configuration flag in a future release.  When I get around to it (could be a while!) I might bother you to test it again. :)

Cheers,
John

Yep, that seems to work perfectly. Thanks! Feel free to get in touch if you want me to test the next version.

I had this same problem, and this fix worked.

What is the reason for prepending the absolute url anyway?

Oh duh, cause they’re not relative to your css dir anymore.

Well, that fixed my base64 encoded stuff, but also broke all my other images.

This fix worked for me as well, although the line numbers are now 811 and 918. Obviously, as noted above, it only works if your other image paths in CSS are already root-relative. Would be great someday to have a more “official” fix… perhaps something as simple as a check in the Minify code for the string “data:image” at the beginning of a URL.

Hi Eli,

In the upcoming release of Minimee 2, this issue will be ‘officially’ dealt with - the newest versions of the Minify’s UriRewriter class does exactly as you suggests, looking for the data protocol and skipping if found.

If you’re willing to test, the beta of Minimee 2 is available on my Github account, any feedback is greatly appreciated:

https://github.com/johndwells/Minimee/tree/version2

Cheers,
John

Wow! So much good new stuff in v2! I will install it this afternoon and start playing around. I see you’ve already fixed my other outstanding issue, root-relative urls for https support. Thanks!

Although I know now it’s been fixed in the newest release I would like to share I had the same problem. Very glad to see it’s been fixed! Good support on a free add-on, thanks!